search

aws-amplify / amplify-cli

The AWS Amplify CLI is a toolchain for simplifying serverless web and mobile development.
Apache License 2.0
2.82k stars 821 forks source link

nodjs update to 12 for Lambda UpdateRolesWithIDPFuncti... #7469

Closed al3x88 closed 3 years ago

al3x88 commented 3 years ago

Note: If your question is regarding the AWS Amplify Console service, please log it in the AWS Amplify Console repository

Which Category is your question related to? amplify lambda

Amplify CLI Version 4.22.0

What AWS Services are you utilizing? I am using S3 with iOS Amplify. The 2 Lambda functions called:

that have been created automatically with the installation process, must be update to Nodejs 12 or higher ( aws end of service policy). Is there a safe way to do it?

Provide additional details e.g. code snippets

jhockett commented 3 years ago

Hi @al3x88, can you update to the latest version of Amplify CLI? The newer version will upgrade your functions automatically for you.

al3x88 commented 3 years ago

Hi @jhockett ! Updating Amplify cli will require to update cocoa pod Amplify as well ? I am just worried to break up my uploading controller on iOS....

akshbhu commented 3 years ago

Hi @al3x88

You can update to amplify cli latest version 4.52.0 and lambda runtime migration for these will be done automatically. updating to latest version also wont affect your project.

mrducky4 commented 3 years ago

I am also trying to get these lambda functions updated from runtime nodejs10.x. What is the workflow to get these lambda functions updated after I update my amplify cli version? I tried amplify pull then amplify push but it just says there are no changes detected and it doesn't do anything.

jhockett commented 3 years ago

@mrducky4 the Lambda functions will automatically update the node version when pushed with an update. You can add a comment or add a newline to your source code to trigger change detection. You can also bump the version listed in your Lambda function's package.json to achieve the same result.

akshbhu commented 3 years ago

Can you check whats your project version in ```amplify/.config.project-config.json? amplify migration happens when you a push if project version is less than 3.1.

Also can you tell me what files in your project are currently on old nodejs runtime?

mrducky4 commented 3 years ago

@jhockett what source code? These lambda functions are created by amplify and I have no idea what they do. The two function names are:

These functions seem to be associated with my Auth resource that uses a Cognito user pool. From cloudwatch logs, it seems like these functions were invoked exactly once when I deployed the project long ago, so I'm not sure if they are even relevant after initial deployment.

I can't find any package.json for these functions, so I don't know how to follow your instructions. Please help.

mrducky4 commented 3 years ago

@akshbhu my project-config.json has version 3.1. amplify-cli updated this, as the version that is committed in my repo is 3.0.

I don't know about "what files in my project are on the old runtime". All I know is the lambda function names, see my previous comment, which are also the same as the functions in the original post that started this issue.

Thank you for helping.

mrducky4 commented 3 years ago

Can anybody tell me if these lambda functions that amplify creates have any use after initial deployment? Is it even worth it to try to upgrade the nodejs runtime? Is it safe to just update the runtime version in the AWS Lambda Console?

Thanks for any additional guidance you can provide.

kaustavghosh06 commented 3 years ago

@al3x88 are you still blocked on this issue? @mrducky4 These Lambda resources are Custom AWS Lambda resources used to configure/update resources for which there isn't any native CloudFormation support. This would be used when you decide to update/delete your AWS resources which is managed by these Lambda custom resources.

kaustavghosh06 commented 3 years ago

Closing this issue as the migration for the latest node version is covered as a part of the latest version of the CLI. Please let me know if you're still stuck on this or have more questions.

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.