search

aws-amplify / amplify-hosting

AWS Amplify Hosting provides a Git-based workflow for deploying and hosting fullstack serverless web applications.
https://aws.amazon.com/amplify/hosting/
Apache License 2.0
450 stars 113 forks source link

Amplify app created with CloudFormation doesn't detect Framework #1669

Open aethr opened 3 years ago

aethr commented 3 years ago

Describe the bug We have an Amplify app built with Vue.js and cypress tests, set up in a standard way using vue-cli. We have noticed that although we followed the steps and amplify.yml for Cypress from https://docs.aws.amazon.com/amplify/latest/userguide/running-tests.html we have never seen the Test phase in our app overview and the output in the Test tab has always been a plain text log.

Our Amplify app is created and managed using CloudFormation, but recently after having some issues with Cypress tests in the build, one of our devs tried creating an Amplify app from the same repo by clicking through the Amplify AWS console UI. In the click-opsed Amplify app, the Test phase appears and the nice Cypress UI.

The main difference we noticed is under App Settings -> Gemeral -> App details, the Framework in the click-ops'd app says "Vue - Cypress" where the CloudFormation app is empty.

To Reproduce Steps to reproduce the behavior:

  1. Create a basic Vue.js app with Cypress using vue-cli
  2. Follow the steps to add amplify.yml in https://docs.aws.amazon.com/amplify/latest/userguide/running-tests.html
  3. Create and deploy an Amplify app connected to the repo using CloudFormation
  4. See the missing Test phase and no Framework detected

Expected behavior I would expect the Framework to be detected whether I create the Amplify app using CloudFormation, amplify-cli or the AWS Console.

Additional context The click-ops'd Amplify app id: damb55yfg0epj CloudFormation Amplify app id: d2q1dmijh1v0iu

Athena96 commented 3 years ago

Hi @aethr, thanks for reaching out. This is definitely a bug, currently we are only detecting the app Framework in the front-end create flow, as you already figured out. I will mark this as a bug and we will prioritize it in our backlog. Thanks and sorry for that you faced this issue.

andrewgadziksonos commented 3 years ago

Hey @Athena96 - I'm also running into this issue with NextJS apps created from CDK/CloudFormation. Do you happen to have any updates you can share with us?

Thank you in advance!

wturon commented 1 year ago

Hello! - I'm also running into this issue. I have a NextJS 13 app that deploys with a missing Framework property. All of the Amplify config is defined in CloudFormation templates and deployed via Serverless Framework.

When I recreate the deployment manually (via the AWS console) it works perfectly. And, like @aethr mentioned, the main difference I've noticed is the missing Framework property in the general settings of the Amplify app. Any guidance?

Thank you so much in advance!

github-actions[bot] commented 1 year ago

This has been identified as a feature request. If this feature is important to you, we strongly encourage you to give a 👍 reaction on the request. This helps us prioritize new features most important to you. Thank you!

calavera commented 1 year ago

CloudFormation works locally, and it doesn't have any knowledge to detect that information from your local repository. You need to set those fields directly in your CloudFormation template at the moment.