search

aws-amplify / amplify-hosting

AWS Amplify Hosting provides a Git-based workflow for deploying and hosting fullstack serverless web applications.
https://aws.amazon.com/amplify/hosting/
Apache License 2.0
450 stars 113 forks source link

Support Next.js 12 #2343

Closed quinnturner closed 1 year ago

quinnturner commented 2 years ago

Next.js v12 was just announced by Vercel. This issue is requesting for Next.js v12 support on Amplify Hosting.

Here's a checklist for general support. Some of these may Just Work ™️ out of the box; I haven't tested much.

Known issues at this time:

ChrisAtVirtueraDev commented 1 year ago

ISR ist just getStaticProps with revalidate  on return

  export const getStaticProps = async (context) => {

      return {

        props: {

           

        },

        revalidate: NEXT_PAGE_REVALIDATION_TIME, // in  seconds

    };

};

            Mit freundlichen Grüßen,

  Christian Müller

   

  https://www.virtuera.dev/

Virtuera Development Christian Müller e.U. Mohsgasse 17-19 · 1030 Vienna · Austria

Christian Müller @. @.>

Software Services Systems Integration Digital Design

          From: Mike Francis @.> Sent: Thursday, 17 November 2022 10:23 To: aws-amplify/amplify-hosting @.> Cc: Christian Müller @.>; Manual @.> Subject: Re: [aws-amplify/amplify-hosting] Support Next.js 12 (Issue #2343)

  Our build time (~4 mins) is a third of what it is on the current Amplify hosting (~12 mins), which is great to see!

Did a quick Lighthouse test and the perf scores (TTI, FCP, LCP) are all the same as our current production non-beta app.

Struggling to find any decent guides about setting up ISR though, can anyone help there?

— Reply to this email directly, view it on GitHub https://github.com/aws-amplify/amplify-hosting/issues/2343#issuecomment-1318332154 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AVIN7VSCZR3MDLCXOBEAQRDWIX2QNANCNFSM5GYHQFGA . You are receiving this because you are subscribed to this thread.Message ID: @. @.> >

aurelien-gaillard commented 1 year ago

The migration didn't work well for me. I have 3 branches in amplify, master, test, demo. the upgrade launch a build only on master branch with last commit message [App configuration change] But when I check the result of this build, I have a version of my app which is 2 weeks old, corresponding to test or demo branch.

It looks like the upgrading is mixing up the attached branches. I don't know what to do now. Disconnect/reconnect all branches ?

sync2920 commented 1 year ago

The same thing was happening to me. In my case, it was due to the fact that the "Rewrites and Redirects" were still set to redirect to the old cloudfront distribution.

aurelien-gaillard commented 1 year ago

It looks that making a manual click on Redeploy this version on all my branches solved the problem. The "Rewrites and redirects" has been cleared in the process.

ajest commented 1 year ago

Could it be that the distributions created by amplify are no longer visible from the cloudfront page?

we don't create distributions in your account anymore.

Where do you create the resources? Are they no more visible for us anymore?

michrome commented 1 year ago

Could it be that the distributions created by amplify are no longer visible from the cloudfront page?

we don't create distributions in your account anymore.

Where do you create the resources? Are they no more visible for us anymore?

That's correct @ajest . A fully managed hosting infrastructure means fewer resources for you to manage in your AWS account.

renchris commented 1 year ago

How would I check where my Amplify URL "rewrites and redirects" to for which CloudFront distribution? How would I update it to reference back to the correct distribution?

renchris commented 1 year ago

I have also tried "redeploy this version". And also tried resetting my zone files with my domain provider. Both didn't solve my issue

renchris commented 1 year ago

I manually took the "Distribution domain name" of the correct CloudFront distribution resource (ex. a12bc3defghijk.cloudfront.net) and copied and paste it in the "Rewrites and redirects" tab under Amplify source address of /<> and destination address of ex. https://k32ji1hgfedcba.cloudfront.net/<>

So replaced https://**k32ji1hgfedcba.cloudfront.net*/<> with a12bc3defghijk.cloudfront.net

calavera commented 1 year ago

@renchris please open a new issue with all the details about your app. Our support team can help you with that, but we need some additional information that can be lost in this thread.

calavera commented 1 year ago

We've published documentation about how to safely migrate along with information about how Next.js 12 features work with this change: https://docs.aws.amazon.com/amplify/latest/userguide/update-app-nextjs-version.html

michrome commented 1 year ago

I am pleased to share we have now launched support for Next.js 12 and 13. For more information, please see our blog post at https://aws.amazon.com/blogs/mobile/amplify-next-js-13

If you run into issues with Next.js 12 or 13, please open a new issue so we can track it specifically. Thank you everyone for your patience and support, particularly the generous beta testers. It's much appreciated.

github-actions[bot] commented 1 year ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

calavera commented 1 year ago

Thanks everyone here from your feedback. We're locking this issue so new messages don't get lost in this very long thread. Please, make sure to read the migration guidelines before changing your production apps. If you need any assistance, don't hesitate to open a new issue. 🙏