search

aws-amplify / amplify-hosting

AWS Amplify Hosting provides a Git-based workflow for deploying and hosting fullstack serverless web applications.
https://aws.amazon.com/amplify/hosting/
Apache License 2.0
460 stars 116 forks source link

Manual Deployment no longer reflecting changes #2860

Closed dereke55 closed 2 years ago

dereke55 commented 2 years ago

Before opening, please confirm:

App Id

d1prdls927k8sp

Region

us-east-2

Amplify Hosting feature

Manual deploys

Describe the bug

Upon building React application locally, and then 'drag & drop' the build folder from local windows explorer onto the Choose files area of the AWS UI, wait for the deployment to complete - status changes to Deployment successfully completed, and then refreshing web page (via custom domain), the changes are not reflected.

Expected behavior

Upon successful deployment, and refresh of web page, the changes should be reflected

Reproduction steps

  1. Generate new React build locally via yarn build
  2. Drag and Drop the build folder from Windows Explorer on to Choose files portion of the AWS Web UI
  3. Wait for deployment to complete - status changes to Deployment successfully completed
  4. Refresh web page via custom domain

Build Settings

No response

Additional information

dereke55 commented 2 years ago

Upon further testing, it seems the changes ARE reflected on the "App Id" subdomain: https://[app_name].[app_id].amplifyapp.com but are not being displayed when using the custom domain

greendrake commented 2 years ago

I just started using Amplify yesterday and bumped into this exact problem when trying to update the app. Did it ever work before? Maybe it only works when deploying from repositories?

P.S. It looks like this issue is probably the same as this one: https://github.com/aws-amplify/amplify-hosting/issues/2846 P.S.2 I note that the CloudFront distribution serving the app does not belong to the AWS account. Apparently, it is managed (which itself is questionable — how does billing for it work?). If it was accessible, it would be possible to simply create an invalidation.

dereke55 commented 2 years ago

Thank you @greendrake for referencing #2846 - I missed this.

I have deployed this way for over a year without issue, so I'm not sure what has changed.

re: CloudFront - when originally setting up the Amplify project and deployment, there was some "automagic" related to CloudFront. I'm not following re: "I note that the CloudFront distribution serving the app does not belong to the AWS account".

It does feel like something has changed or there is a sync / cache issue.

greendrake commented 2 years ago

I'm not following re: "I note that the CloudFront distribution serving the app does not belong to the AWS account".

I just mean that the CF distribution (which is part of the Amplify deployment) is not accessible to us. You only can see it referenced in Route 53 attached to your custom domain A record, but if you go to the CloudFront console it won't be in there (otherwise we could just create an invalidation to bust the cache).

dereke55 commented 2 years ago

Ah yes. I completely agree.

dereke55 commented 2 years ago

Any update on this (or related) issue? I don't want to start changing DNS settings and/or recreate Amplify project if there is information that can help debug and resolve this.

greendrake commented 2 years ago

Any update on this (or related) issue?

I have ditched Amplify for S3+CloudFront, and happy with it.

dereke55 commented 2 years ago

Any update on this (or related) issue?

I have ditched Amplify for S3+CloudFront, and happy with it.

Good to know. Thank you!

dereke55 commented 2 years ago

I was able to force the update / sync by following the steps from @soplan in #2844:

oliver-leung commented 2 years ago

We've root-caused the issue and are currently working on the fix. In the meantime, please use one of the following workarounds:

  1. Disable, then re-enable the custom domain in App Settings > Domain Management > Manage subdomains
  2. Only upload compressed .zip build artifact folders
ghost commented 2 years ago

Closing as duplicate of #2846. Please defer to that issue for any updates.

github-actions[bot] commented 2 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.