Amplify Github App posts empty preview link on the PR even if deployment was skipped because of `AMPLIFY_DIFF_DEPLOY`

taraspos commented 1 month ago

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have removed any sensitive information from my code snippets and submission.

Amplify Hosting feature

Deployments, Frontend builds, Git providers, Web previews

Is your feature request related to a problem? Please describe:

We are using Amplify Hosting with a connected GitHub provider.

When using Amplify Hosting with GitHub Pull Request previews, and when AMPLIFY_DIFF_DEPLOY is enabled, deployments are skipped as expected if no changes are detected. However, the GitHub Amplify App still posts a preview URL in Pull Request comments. This URL leads to a 404 error (or the Amplify welcome page) because nothing was deployed.

Describe how you'd like this feature to work

Amplify PR Preview URL should be posted only if deployment happened.

github-actions[bot] commented 1 month ago

This has been identified as a feature request. If this feature is important to you, we strongly encourage you to give a 👍 reaction on the request. This helps us prioritize new features most important to you. Thank you!

taraspos commented 1 month ago

Related issues:

aws-amplify / amplify-hosting