search

aws-amplify / amplify-hosting

AWS Amplify Hosting provides a Git-based workflow for deploying and hosting fullstack serverless web applications.
https://aws.amazon.com/amplify/hosting/
Apache License 2.0
461 stars 116 forks source link

PR previews for forks #508

Open ericclemmons opened 4 years ago

ericclemmons commented 4 years ago

Is your feature request related to a problem? Please describe.

PR previews only work for branches on origin, not for forks.

Describe the solution you'd like

Every PR for a front-end site should generate a PR preview.

Additional context

Example of a PR with a preview (notice the branch name & the preview link under "Checks"):

Example of a PR without a preview (notice the forked branch name & how "Checks" doesn't have a preview):

jbeveland27 commented 4 years ago

Just adding that I'd really like to see this feature. Our team functions primarily through a fork+PR flow and it's how we encourage others to interact with our project(s) as well. Having PR previews work for forks is highly desirable.

zstix commented 4 years ago

+1 for this feature. Our team accepts contributions via the fork & PR workflow.

brentley commented 4 years ago

Another +1... I came here after spending quite a while setting up previews only to realize our forking model doesn't work. that could be called out in the documentation until the feature is added. thanks!

jpvajda commented 4 years ago

+1 one for this feature as well!

swaminator commented 4 years ago

@jpvajda @ericclemmons @brentley @jbeveland27 @zstix we have implemented this and the feature is rolling out to all regions over the next week.