Closed capitaldotcodes closed 1 year ago
chrisbonifacio
commented
2 years ago Hi @capitaldotcodes 👋 thanks for raising this issue. Could you please share your schema to see what auth rules you might be using?
Is the model authorized to be created by public access (API_KEY) or by private access (Cognito User Pools, OIDC, IAM, etc)?
Or are you seeing this behavior with any model regardless of the auth rules set?
capitaldotcodes
commented
2 years ago I'm using Cognito User Pools i've tested in a very skinny example app and can reproduce the behaviour.
@model
@auth(
rules: [
{ allow: owner }
]
)
{
id: ID!
name: String
owner: String
}When the user is signed out the mutation event is removed you can tell it is created as the local storage index increases.
dpilch
commented
2 years ago Possibly related to #6534.
Could further explain your use case for creating models when no user is signed in?
Or is it more the following case?
capitaldotcodes
commented
2 years ago The app is offline first and does not require an account to use. When the user creates an account the models created locally should automatically sync. Given that when the mutation events are left in the queue amplify handles this seamlessly it would seem strange to imply the use case was not supported. This was how the datastore worked in all the AWS provided demo apps.
I don't think it is related to #6534. To me it is a problem with what is and is not a retry-able error. The no current user error should be a retry-able error and the mutation event shouldn't be deleted. Alas at the moment it retries, fails, gives up and deletes the event after logging 'done retrying'.
No the method to reproduce is 1.) Without a signed in user create a model 2.) In Application on chrome browser view sync_MutationEvent and note that mutation event has been deleted 3.) Create user and login 4.) Query for created model and see that it is available but has not been synced remotely
dpilch
commented
2 years ago Ok, I understand now. I agree it is strange behavior that the mutations are deleted. I'll look into some solutions for this.
david-mcafee
commented
1 year ago @capitaldotcodes - my apologies if I'm not understanding the reproduction steps correctly, but from what I see you're attempting to create a model when a user is not signed in, but your schema does not allow for public CRUD access - is that correct? If so, you would need to update your schema to allow public access, or only perform the mutation when the user is signed in. If I'm not understanding correctly, please let me know. Thank you!
david-mcafee
commented
1 year ago @capitaldotcodes - closing this ticket as we have not heard back from you. If you need further assistance, please let us know!
Before opening, please confirm:
JavaScript Framework
Angular
Amplify APIs
DataStore
Amplify Categories
Not applicable
Environment information
Describe the bug
When a user is signed out any model which is created via Datastore.save() persists but after erroring and retrying the mutation is deleted from the queue.
One the mutation event is deleted the model is never synced and remains locally available but not remotely available.
The responsible line of code is below. Commenting out this dequeue operation appears to fix the problem. What the consequences are of doing this I am unaware.
https://github.com/aws-amplify/amplify-js/blob/7656bc8a9864af05618d3fd794a48217e9ec7295/packages/datastore/src/sync/processors/mutation.ts#L207
Expected behavior
When a user is not logged in and creates models mutation events should not be deleted and on user signup i.e Datastore.stop Datastore.start the mutations should be processed by the sync engine.
I can see why this might be useful in some use cases but the developer has control of the local Datastore via Datastore.clear and thus the default behaviour should be that the mutations remain in the queue.
Reproduction steps
1.) Without a signed in user create a model 2.) In Application on chrome browser view sync_MutationEvent and note that mutation event has been deleted 3.) Create user and login 4.) Query for created model and see that it is available but has not been synced remotely
Code Snippet
Log output
aws-exports.js
No response
Manual configuration
No response
Additional configuration
No response
Mobile Device
No response
Mobile Operating System
No response
Mobile Browser
No response
Mobile Browser Version
No response
Additional information and screenshots
No response