aws-amplify / amplify-js

A declarative JavaScript library for application development using cloud services.
https://docs.amplify.aws/lib/q/platform/js
Apache License 2.0
9.42k stars 2.12k forks source link

Immer v10 #11433

Open kachkaev opened 1 year ago

kachkaev commented 1 year ago

Is this related to a new or existing framework?

No response

Is this related to a new or existing API?

DataStore

Is this related to another service?

No response

Describe the feature you'd like to request

I would like to see immer to be bumped from v9 to v10 inside @aws-amplify/datastore so that my package manager could deduplicate it with my direct dependency.

Current result of pnpm why immer:

@aws-amplify/ui-react 4.6.4
├─┬ @aws-amplify/ui 5.6.4
│ └─┬ aws-amplify 5.2.4 peer
│   └─┬ @aws-amplify/datastore 4.4.1
│     └── immer 9.0.6
...
aws-amplify 5.2.4
└─┬ @aws-amplify/datastore 4.4.1
  └── immer 9.0.6
...
immer 10.0.2
use-immer 0.9.0
└── immer 10.0.2 peer

Immer v10 was released on April 17, see changelog: https://github.com/immerjs/immer/releases/tag/v10.0.0

Describe the solution you'd like

I would like immer to be updated in this file:

https://github.com/aws-amplify/amplify-js/blob/ffe65eaedc5f4629cf917926666a328aa6fbba9d/packages/datastore/package.json#L64

Describe alternatives you've considered

Additional context

No response

Is this something that you'd be interested in working on?


* Depends on what browsers are already supported by Amplify

⚠️ [breaking change] Immer 10 only supports modern browsers, that have support for Proxy, Reflect, Symbol and Map and Set.

cwomack commented 8 months ago

@kachkaev, thank you for opening this feature request. I left a comment on the associated PR you've linked, but we'll keep this open as we reevaluate our browser support in future major versions.