feat(storage): calculate crc32 by default and deprecate md5 - Githubissues

aws-amplify / amplify-js

A declarative JavaScript library for application development using cloud services.

https://docs.amplify.aws/lib/q/platform/js

Apache License 2.0

9.44k stars 2.13k forks source link

feat(storage): calculate crc32 by default and deprecate md5 #13968

Closed AllanZhengYP closed 3 weeks ago

AllanZhengYP commented 3 weeks ago

Description of changes

Remove the checksumAlgorithm option from upload(single & multipart) API and instead calculate the crc32 checksum by default.
Deprecate the MD5 checksum when objectLockEnabled configuration is set. It's not useful since we send crc32 by default now.
Update tests accordingly.

Issue #, if available

Description of how you validated changes

[x] Unit test
[ ] Integration test
[x] Performance test on Web.
[ ] Performance test on RN.
[ ] Smoke test on object locked enabled bucket.

Checklist

[ ] PR description included
[x] yarn test passes
[ ] Unit Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

[ ] Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
[ ] New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.