Missing check for null user

[ldgarcia]

Error:

Object {[ERROR] 07:53.700 Authenticator: TypeError: Cannot read property 'getSession' of null
    at http://localhost:8081/index.bundle?platf…}

Current code:

if (Platform.isReactNative) {
  const that = this;
  return this.getSyncedUser().then(user => {
    return new Promise((resolve, reject) => {
      // null user here results in TypeError
      user.getSession(function(err, session) {
        if (err) {
          reject(err);
        } else {
          resolve(user);
        }
      });
    });
  });
}

Proposed change:

if (Platform.isReactNative) {
  const that = this;
  return this.getSyncedUser().then(user => {
    if (!user) { return Promise.reject('No current user in userPool'); }
    return new Promise((resolve, reject) => {
      user.getSession(function(err, session) {
        if (err) {
          reject(err);
        } else {
          resolve(user);
        }
      });
    });
  });
}

Please see: https://github.com/aws/aws-amplify/blob/72159fb67735c0361e9e61903f4995ff0d95e828/packages/aws-amplify/src/Auth/Auth.ts#L393

[mlabieniec]

@ldgarcia did you want to submit a pr for that update?

[ldgarcia]

@mlabieniec yes, I can also submit the change for #304, if you are ok with those changes.

[mlabieniec]

Looks ok to me, let's see what @powerful23 thinks. you can submit the PR we can review it there, thanks

[ldgarcia]

Ok, will do

[powerful23]

@ldgarcia Good catch!

[github-actions[bot]]

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.