aws-amplify / amplify-js

A declarative JavaScript library for application development using cloud services.
https://docs.amplify.aws/lib/q/platform/js
Apache License 2.0
9.41k stars 2.11k forks source link

Allow to set multiple notification channels on android #8980

Open DeniferSantiago opened 2 years ago

DeniferSantiago commented 2 years ago

Is this related to a new or existing framework?

React Native

Is this related to a new or existing API?

Push Notifications

Is this related to another service?

pinpoint

Describe the feature you'd like to request

In android the notification channel used is static and by default it has the name of the application package, which is a bad experience for people who enter the configuration.

Notification settings

The ideal is to be able to establish the notification channel through the payload of the push notification, this would not allow to establish several notification channels and that the user can more easily configure the notifications that are shown.

Facebook Notification settings

The code currently in use looks like this:

Code Code

Describe the solution you'd like

I would like that we could send a properties with the id of the channel and the name of the channel in the payload of the notification.

Describe alternatives you've considered

A possible solution would be this simple change in the code:

Code

Additional context

No response

Is this something that you'd be interested in working on?

tannerabread commented 1 year ago

Original comment from linked issue #5203

Could you please add ability to change notification channel name from default package name to something custom for android? This value is visible for user at system notification settings screen.

It will be ok for me when we can pass custom NOTIFICATION_CHANNEL_NAME with PushNotifications configuration.

There are no other ways to do this because this value is just hardcoded in sources. Please check initializing And then usage