aws-amplify / amplify-js

A declarative JavaScript library for application development using cloud services.
https://docs.amplify.aws/lib/q/platform/js
Apache License 2.0
9.43k stars 2.13k forks source link

react example is NOT a PWA #930

Closed whatsdis closed 6 years ago

whatsdis commented 6 years ago

I don't understand how the AWS Mobile React app found at https://console.aws.amazon.com/mobilehub/home?#/ is a PWA.

When I view it on my Galaxy s8, the login form is very tiny....

also when I preview it in other mobile modes via chrome inspector the same results...

this is disappointing to see Amazon label it as a PWA when it's not actually accessible.

mlabieniec commented 6 years ago

@whatsdis 100% agree, we will work with the mobile hub team to get this address asap, thank you for pointing that out. Our PWA example is forth coming and will include service worker integration and responsive layout.

whatsdis commented 6 years ago

Thank you, I didn't meant to be too harsh here and normally I wouldn't give a crap but I've spent the past year working on a large enterprise grade PWA React/Redux application so I couldn't help but point this out! I naturally test almost any PWA I come across these days.

Any estimates on date?

mlabieniec commented 6 years ago

No problem! I don't currently have a date, but it is part of our backlog and should start in the next couple sprints.

swaminator commented 6 years ago

@whatsdis: We can't seem to find where you read that the React starter is a PWA. If you can send a screenshot that will be great!

swaminator commented 6 years ago

Closing this issue as OP hasn't responded to where he saw the PWA text. Please re-open if you identify where this text appears.

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.