aws-amplify / amplify-js

A declarative JavaScript library for application development using cloud services.
https://docs.amplify.aws/lib/q/platform/js
Apache License 2.0
9.36k stars 2.1k forks source link

feat(datastore): custom pk support #9432

Closed iartemiev closed 1 year ago

iartemiev commented 2 years ago

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 2 years ago

Codecov Report

Merging #9432 (2d69dbe) into main (0729e68) will decrease coverage by 0.43%. The diff coverage is 75.33%.

@@            Coverage Diff             @@
##             main    #9432      +/-   ##
==========================================
- Coverage   84.14%   83.70%   -0.44%     
==========================================
  Files         253      253              
  Lines       18287    18666     +379     
  Branches     3923     4013      +90     
==========================================
+ Hits        15387    15625     +238     
- Misses       2810     2952     +142     
+ Partials       90       89       -1     
Impacted Files Coverage Δ
packages/datastore/__tests__/model.ts 100.00% <ø> (ø)
...ages/datastore/src/sync/processors/subscription.ts 73.58% <ø> (ø)
packages/datastore/src/sync/index.ts 73.10% <37.50%> (-0.15%) :arrow_down:
packages/datastore/src/types.ts 76.00% <38.09%> (-5.30%) :arrow_down:
packages/datastore/src/sync/processors/mutation.ts 72.82% <47.61%> (-1.94%) :arrow_down:
packages/datastore/__tests__/helpers.ts 87.87% <50.00%> (-2.13%) :arrow_down:
packages/datastore/src/sync/utils.ts 87.83% <58.33%> (-2.20%) :arrow_down:
.../datastore/src/storage/adapter/IndexedDBAdapter.ts 80.67% <65.33%> (-7.48%) :arrow_down:
...tastore/src/storage/adapter/AsyncStorageAdapter.ts 79.33% <69.23%> (-9.47%) :arrow_down:
packages/datastore/src/storage/storage.ts 92.63% <71.87%> (-5.02%) :arrow_down:
... and 12 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 3627b19eea4f2ebb550f01e9e6a9adb09762269e into 08e01b1c09cfab73f2eb1b1b18fe1a696e2a028f - view on LGTM.com

new alerts:

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 7c83ef5c4ec56a108ee80a4753912f7b74f4aadc into 08e01b1c09cfab73f2eb1b1b18fe1a696e2a028f - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 3 alerts when merging adbf3c0e114ce95ece65b9addb20bc580f7000ab into 9cca114895d931365be4d22f52adb60232a3d242 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging b6948af7d9fa776433f2a0fe9d40448729b5ab6e into 9cca114895d931365be4d22f52adb60232a3d242 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging ab9f642dc6e66736b93325294128e94dac1c64f7 into 9cca114895d931365be4d22f52adb60232a3d242 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging e880b14033357b4dd1c6ff35a3cf12a04fd91f0e into 870ec87a6b5d6f3aa3a85551faac87a208c354a2 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 5719d1cb125c34b34d07d2f1dd1bb3348d6fdf60 into de0441b4fa67409ccbc630c42890e2c58ee779fb - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging aa4b09332f549dc19eafa8dacb156926e2d54997 into f6e2ca25785bb30ab6040f1f8c163e6069ccc392 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 5275728e71a43fd341b27c2dd730d14b8aeec332 into 8e49b0d53bc7a8c373289cf5aa2172284c76ecd6 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging daed762390ba65c8ce002d3aadcee85679fbb82f into 8e49b0d53bc7a8c373289cf5aa2172284c76ecd6 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 13 alerts when merging 420e34e2edbc04c021a7e48441726d3d4d931401 into 0729e683a01536e583e707600be76077d8e16050 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 13 alerts when merging 621e31a2987742f13b165122e1a5c6328eb589fa into 0729e683a01536e583e707600be76077d8e16050 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 3 alerts when merging 9527bfdc3ee5d742df7f8493123d594b662f87da into 366c32e2d87d73210bbd01ca1da55a5899f5a503 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 3 alerts when merging 1aac5062563a2bcc723585d5c73597de4bdd7232 into 366c32e2d87d73210bbd01ca1da55a5899f5a503 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 3 alerts when merging 0b6fc9dc572459650749e5beb992c5060eadb920 into 366c32e2d87d73210bbd01ca1da55a5899f5a503 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 3 alerts when merging 09912f50299df6581e7c6a5ecb365d39d15353c4 into d5cb22386653916ff842153c88080f92c6f604b5 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 2 alerts when merging 5d50d43fe37cc8046fbb69180ba31e527993ee84 into eb7a2c49b4d2cefa5c611f331b0d0ebe397cd88a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 2 alerts when merging e6bcf1cd8128b132b9bc06f98bb6694cf23e41b2 into 186349e1ec885f1e73ba24f71c3cd7ab4d88fe8a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging a36c5b600189ffcf24f9d2d584efa3e6da78b8db into 186349e1ec885f1e73ba24f71c3cd7ab4d88fe8a - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging c98161bda6d3958b3c246a9afacde029d607e406 into dbe57a4ae45fdac9f8a5990065495b0d04639267 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging ba9691cc0f247a11c7d46e18aa20003293a3f145 into 360bde20716778b69af339f4f66b42c05ccf4639 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 7579e87aa7dccc152853050e64ea317ff1893f2e into 88a9ec97fca2eb19c9cc9496b8b7d25b75f02073 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 9e4c95b205eaa9a2f164822b1da951cb39be9336 into 88a9ec97fca2eb19c9cc9496b8b7d25b75f02073 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert and fixes 1 when merging 82cbe2626cfd9bb8480a15da23b2b70b2216e0c3 into 511751a56b6bb567a5d8b874f4de79a13e21a773 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert and fixes 1 when merging b9656543bd5572aa18162805a2370d676961563e into 511751a56b6bb567a5d8b874f4de79a13e21a773 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert and fixes 1 when merging 50089b2333851b1ed113d6fc8775590d753ce5e4 into 1ad20b2bcade74f197705b744d8af9bb5ab3ced4 - view on LGTM.com

new alerts:

fixed alerts:

GuruprasadHebbar commented 1 year ago

Team when this issue will be fixed and available for use? Is there any ETA

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert and fixes 1 when merging b4741c0cab67d99228985f6da46e490971d16ca2 into 1ad20b2bcade74f197705b744d8af9bb5ab3ced4 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert and fixes 1 when merging 8203c3a783aa6e7e69a41856d94b33742f99a370 into 1ad20b2bcade74f197705b744d8af9bb5ab3ced4 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 283a10c9c0bf9fe1b00395cccc096f898db9b89a into 41ab57a854676813c3f9d89d647a8ac8f7b2c65f - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 4d76642c14842583076138d8c1f8f16815fc5e5b into 41ab57a854676813c3f9d89d647a8ac8f7b2c65f - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert and fixes 1 when merging 77c0f72e3af0d56387944dee8f96b137bfbf1484 into 4988d51a6ffa1215a413c19c80f39a035eb42512 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging b96794552be2cddf1b192a6e0b8380d2afa6d2b0 into 4988d51a6ffa1215a413c19c80f39a035eb42512 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 84422eb6a62a5ce323f655ab96333ac382aa50cf into 4988d51a6ffa1215a413c19c80f39a035eb42512 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging bc3dd8abf065209b5c251458c28b2ec50abda1f3 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 910ef3e8ecd1cf2ae46a3b8aa19a28e13fab54a6 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 626dcb1ddbbdb868578688b747669b0d2f1089b2 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging bc4816a505393bd52ccc3da35c72119fadf7b07e into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging e11360a3cf5f3da6f47808e68f5e606917772843 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 314fcad82e90c359751072086eaae4f3c4d6354d into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 2b9e5b0d97525b4f6c953020bd4ed21868c985fb into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 2bf14f62a152df5c09b10a2cd2f76c17b35d3904 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 956974af8edbbd5f1a7ea9b0b1463e778421274c into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging de5000e6839d0817da172e161e28641b58f341e9 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging c0375447cd2a4813ca0d586da0b760a664d3d7fa into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 9e4e1a01bf2c457c7657ee34f46cbed386fd32d5 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging 280f17fbb5abd784dda6f68a6324b85e34b8a786 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging a85979bd285380a0289738173af09fc849506678 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 1 year ago

This pull request fixes 1 alert when merging b26bafc4e7591d2bb5c96cd82844a4b9bbbaa3d0 into 7eec72b9e50b40febbf6a94452a3c8ed15893228 - view on LGTM.com

fixed alerts: