search

aws-amplify / amplify-swift

A declarative library for application development using cloud services.
Apache License 2.0
456 stars 198 forks source link

feat(Storage): Implementing support for multiple buckets #3839

Closed ruisebas closed 1 month ago

ruisebas commented 2 months ago

Issues:

Description

This PR adds multiple bucket support to all Amplify Storage APIs.

All changes have been reviewed in the previous PRs:

General Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.30151% with 79 lines in your changes missing coverage. Please review.

Project coverage is 68.33%. Comparing base (e373bde) to head (49ec259). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...orage/Operation/Request/StorageGetURLRequest.swift 0.00% 10 Missing :warning:
...e/Operation/Request/StorageUploadDataRequest.swift 0.00% 9 Missing :warning:
...e/Operation/Request/StorageUploadFileRequest.swift 0.00% 9 Missing :warning:
...Operation/Request/StorageDownloadDataRequest.swift 0.00% 8 Missing :warning:
...Operation/Request/StorageDownloadFileRequest.swift 0.00% 8 Missing :warning:
...Storage/Operation/Request/StorageListRequest.swift 36.36% 7 Missing :warning:
Amplify/Categories/Storage/StorageBucket.swift 0.00% 7 Missing :warning:
...lugin/AWSS3StoragePlugin+AsyncClientBehavior.swift 50.00% 7 Missing :warning:
...orage/Operation/Request/StorageRemoveRequest.swift 0.00% 6 Missing :warning:
...mplify/Core/Configuration/AmplifyOutputsData.swift 0.00% 4 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3839 +/- ## ========================================== - Coverage 68.39% 68.33% -0.07% ========================================== Files 1082 1084 +2 Lines 37699 37858 +159 ========================================== + Hits 25784 25869 +85 - Misses 11915 11989 +74 ``` | [Flag](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | Coverage Δ | | |---|---|---| | [API_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `69.32% <ø> (ø)` | | | [AWSPluginsCore](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `68.53% <ø> (ø)` | | | [Amplify](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `47.10% <5.55%> (-0.46%)` | :arrow_down: | | [Analytics_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `84.52% <ø> (ø)` | | | [Auth_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `79.27% <ø> (-0.04%)` | :arrow_down: | | [DataStore_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `81.30% <ø> (+0.01%)` | :arrow_up: | | [Geo_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `72.00% <ø> (ø)` | | | [Logging_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `62.95% <ø> (ø)` | | | [Predictions_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `36.86% <ø> (ø)` | | | [PushNotifications_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `86.21% <ø> (ø)` | | | [Storage_plugin_unit_test](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `77.25% <91.33%> (+0.44%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/aws-amplify/amplify-swift/pull/3839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `68.33% <60.30%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.