search

aws-amplify / amplify-ui-swift-authenticator

The Amplify UI Authenticator is a component that supports several authentiation flows using Amplify Authentication.
https://ui.docs.amplify.aws/swift/connected-components/authenticator
Apache License 2.0
15 stars 9 forks source link

fix: Sign in fails when user is auto confirmed after sign up #72

Closed ruisebas closed 6 months ago

ruisebas commented 6 months ago

Issue #, if available:

Description of changes:

When a Sign Up flows is successful, the Authenticator automatically determines the next action based on the result's nextStep. If a user doesn't need confirmation, the next step will be done, in which case the Authenticator will attempt to automatically Sign In.

However, because the user credentials were not yet set, the sign in request failed because it provided empty values.

Other changes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@24f28b8). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #72 +/- ## ======================================= Coverage ? 20.47% ======================================= Files ? 71 Lines ? 3799 Branches ? 0 ======================================= Hits ? 778 Misses ? 3021 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/aws-amplify/amplify-ui-swift-authenticator/pull/72/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | Coverage Δ | | |---|---|---| | [Authenticator](https://app.codecov.io/gh/aws-amplify/amplify-ui-swift-authenticator/pull/72/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify) | `20.47% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-amplify#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.