fix: remove strong reference retain cycle from camera preview view model - Githubissues

aws-amplify / amplify-ui-swift-liveness

This repository offers a UI component for Amazon Rekognition Face Liveness, enabling developers to ensure that only authentic users, and not bad actors using spoofs, can access their services.

https://ui.docs.amplify.aws/swift/connected-components/liveness

Apache License 2.0

8 stars 18 forks source link

fix: remove strong reference retain cycle from camera preview view model #135

Closed phantumcode closed 2 months ago

phantumcode commented 2 months ago

Issue #, if available: https://github.com/aws-amplify/amplify-ui-swift-liveness/issues/129

Description of changes:

Refactor and remove strong reference retain cycle between CameraPreviewViewModel and LivenessCaptureSession
Tested and verified that strong reference doesn't exists when viewed in Xcode's memory graph

Check points: (check or cross out if not relevant)

[ ] Added new tests to cover change, if needed
[ ] Build succeeds with all target using Swift Package Manager
[ ] All unit tests pass
[ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] Documentation update for the change if required
[ ] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.