Closed ruisebas closed 4 months ago
Attention: Patch coverage is 0%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 30.48%. Comparing base (
75a7c3c
) to head (ab1ebf1
). Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...veness/Views/Liveness/LivenessViewController.swift | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of changes:
The
_LivenessViewController
currently centers its camera frame only when its view is loaded, but not when its subviews are laid out. This causes the video feed to appear off-centered when theFaceLivenessDetectorView
is stacked with other components (i.e. headers, navigation bars, etc), or when used in aUIHostingController
.This PR fixes this issue by re-centering the camera frame on
viewDidLayoutSubviews()
.I'm also removing the liveness package being unnecessary copied as a resource for the example HostApp
Check points: (check or cross out if not relevant)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.