aws-amplify / amplify-ui

Amplify UI is a collection of accessible, themeable, performant React (and more!) components that can connect directly to the cloud.
https://ui.docs.amplify.aws
Apache License 2.0
909 stars 289 forks source link

Sign up link still visible when component removed in React Native #3080

Closed greatwitenorth closed 1 year ago

greatwitenorth commented 4 years ago

Describe the bug When using React Native, the sign up link remains visible on the login screen despite removing the SignUp component.

To Reproduce Steps to reproduce the behavior: See code snippet below.

Expected behavior I expect the sign up link to be removed if no SingUp component is present. Alternatively I expect a prop to control the visibility of the sign up link.

Code Snippet The following code will still show a sign up link below the sign in form:

export default (props) => (
    <Authenticator
      hideDefault={true}
      usernameAttributes="email" 
    >
      <SignIn/>
      <Greetings/>
    </Authenticator>
)
Environment ``` System: OS: macOS 10.15.4 CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz Memory: 516.81 MB / 16.00 GB Shell: 5.7.1 - /bin/zsh Binaries: Node: 12.13.0 - ~/.nvm/versions/node/v12.13.0/bin/node Yarn: 1.21.1 - ~/.nvm/versions/node/v12.13.0/bin/yarn npm: 6.12.0 - ~/.nvm/versions/node/v12.13.0/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman Browsers: Chrome: 84.0.4147.125 Firefox: 77.0.1 Safari: 13.1 npmPackages: @apollo/react-hooks: ^3.1.3 => 3.1.3 @babel/core: ^7.0.0 => 7.8.4 @expo/samples: ~36.0.0 => 36.0.0 @expo/vector-icons: ^10.0.6 => 10.0.6 @react-native-community/datetimepicker: 2.1.0 => 2.1.0 @react-native-community/netinfo: ^5.9.6 => 5.9.6 @react-navigation/native: ^5.0.0 => 5.0.0 @react-navigation/web: ~1.0.0-alpha.9 => 1.0.0-alpha.9 apollo-boost: ^0.4.7 => 0.4.7 apollo-cache-inmemory: ^1.6.5 => 1.6.5 apollo-client: ^2.6.8 => 2.6.8 apollo-link: ^1.2.13 => 1.2.13 apollo-link-context: ^1.0.19 => 1.0.19 apollo-link-http: ^1.5.16 => 1.5.16 apollo-link-ws: ^1.0.19 => 1.0.19 apollo-utilities: ^1.3.3 => 1.3.3 aws-amplify: ^3.0.23 => 3.0.23 aws-amplify-react-native: ^4.2.4 => 4.2.4 babel-preset-expo: ~8.0.0 => 8.0.0 deepmerge: ^4.2.2 => 4.2.2 expo: ~36.0.0 => 36.0.2 expo-asset: ~8.0.0 => 8.0.0 expo-constants: ~8.0.0 => 8.0.0 expo-document-picker: ~8.0.0 => 8.0.0 expo-file-system: ^8.0.0 => 8.0.0 expo-font: ~8.0.0 => 8.0.0 expo-image-manipulator: ~8.0.0 => 8.0.0 expo-image-picker: ~8.0.1 => 8.0.2 expo-location: ~8.0.0 => 8.0.0 expo-media-library: ~8.0.0 => 8.0.0 expo-web-browser: ~8.0.0 => 8.0.0 formik: ^2.1.4 => 2.1.4 graphql: ^14.6.0 => 14.6.0 jest-expo: ~36.0.1 => 36.0.1 md5: ^2.2.1 => 2.2.1 moment: ^2.24.0 => 2.24.0 react: ~16.9.0 => 16.9.0 react-dom: ~16.9.0 => 16.9.0 react-native: https://github.com/expo/react-native/archive/sdk-36.0.0.tar.gz => 0.61.4 react-native-cameraroll: ^1.0.0-alpha2 => 1.0.0-alpha2 react-native-dialog: ^5.6.0 => 5.6.0 react-native-elements: ^1.2.7 => 1.2.7 react-native-gesture-handler: ~1.5.0 => 1.5.6 react-native-image-slider-box: ^1.0.12 => 1.0.12 react-native-maps: 0.26.1 => 0.26.1 react-native-material-textfield: shamilovtim/react-native-material-textfield => 0.16.1 react-native-mime-types: ^2.2.1 => 2.2.1 react-native-modal-datetime-picker: ^8.5.1 => 8.5.1 react-native-picker-select: ^6.4.0 => 6.4.0 react-native-reanimated: ~1.4.0 => 1.4.0 react-native-screens: 2.0.0-alpha.12 => 2.0.0-alpha.12 react-native-svg: 9.13.3 => 9.13.3 react-native-swipe-list-view: ^2.4.0 => 2.4.0 react-native-web: ~0.11.7 => 0.11.7 react-navigation: ~4.0.10 => 4.0.10 react-navigation-drawer: ^2.4.4 => 2.4.4 react-navigation-stack: ~1.10.3 => 1.10.3 react-navigation-tabs: ~2.6.2 => 2.6.2 react-number-format: ^4.3.1 => 4.3.1 subscriptions-transport-ws: ^0.9.16 => 0.9.16 npmGlobalPackages: @aws-amplify/cli: 4.27.1 @primecms/cli: 0.3.4-beta.1 @sanity/cli: 0.142.2 @vue/cli: 4.0.5 apollo: 2.22.0 better-react-hubspot-forms: 1.0.0 expo-cli: 3.21.10 gatsby-cli: 2.12.77 graphql-faker: 2.0.0-rc.15 gulp: 4.0.2 hasura-cli: 1.2.2 loadtest: 5.0.1 netlify-cli: 2.59.0 npm: 6.12.0 prisma: 1.30.1 prisma2: 2.0.0-preview019 react-devtools: 3.6.3 strapi: 3.0.0-beta.15 svgo: 1.3.2 typescript: 3.6.2 yarn: 1.21.1 ```

Smartphone (please complete the following information):

It seems like the React library had a fix for this applied but it never made it into the React Native Library.

reesscot commented 1 year ago

The aws-amplify-react-native package has been deprecated. Please upgrade to the new React Native Authenticator and let open a new issue if you are still having problems: https://ui.docs.amplify.aws/react-native/connected-components/authenticator