aws-amplify / amplify-ui

Amplify UI is a collection of accessible, themeable, performant React (and more!) components that can connect directly to the cloud.
https://ui.docs.amplify.aws
Apache License 2.0
913 stars 295 forks source link

fix(react-storage): url encode copy source #6060

Closed AllanZhengYP closed 1 week ago

AllanZhengYP commented 1 week ago

Description of changes

Add URI encoding to the copy source to handle copying the object key containing special characters. Techinically it should be added to the Amplify JS library. However, since customers may have already encode the copy source to workaround this problem, it's not safe to introduce the change in Amplify JS library.

Add this change to StorageBrowser will prevent breaking change but also handle the scpecial characters in the source.

Issue #, if available

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: fede61f4b466311478cb38b4fb4ec5f8048f93a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR