feat: add search results limit message

aws-amplify / amplify-ui

Amplify UI is a collection of accessible, themeable, performant React (and more!) components that can connect directly to the cloud.

https://ui.docs.amplify.aws

Apache License 2.0

913 stars 295 forks source link

feat: add search results limit message #6095

Closed pranavosu closed 1 week ago

pranavosu commented 1 week ago

Description of changes

Warn users when we limit search to 10,000 items in Location Detail
Updated unit tests

Issue #, if available

Description of how you validated changes

Checklist

[ ] Have read the Pull Request Guidelines
[ ] PR description included
[ ] yarn test passes and tests are updated/added
[ ] PR title and commit messages follow conventional commit syntax
[ ] If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 3cba4ec600dd272aedef415242195b03ca768ae4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pranavosu commented 1 week ago

General question should we show this in all pages or just in the last navigated page?

This is just for Search in LocationDetailView. What do you mean by last navigated page?

pranavosu commented 1 week ago

We should add this on CopyView search too, right?

It's more relevant here because include subfolders tends to go through more items. CopyView will have access to hasExhaustedSearch after this is merged, so it should be straightforward to integrate a message. Just need to iron out the details in a follow-up.