chore(storage-browser): Refactor destination - Githubissues

aws-amplify / amplify-ui

Amplify UI is a collection of accessible, themeable, performant React (and more!) components that can connect directly to the cloud.

https://ui.docs.amplify.aws

Apache License 2.0

913 stars 295 forks source link

chore(storage-browser): Refactor destination #6115

Closed cshfang closed 4 days ago

cshfang commented 5 days ago

Description of changes

This PR

Refactors the UploadView and CopyView to use the same composable ActionDestinationControl
Fixes issues with the current DestinationControl which caused it not to work with prefixes which contained / characters
Extracts logic from the useNavigation hook to be reused in a new useActionDestination hook

Issue #, if available

Description of how you validated changes

Checklist

[x] Have read the Pull Request Guidelines
[x] PR description included
[x] yarn test passes and tests are updated/added
[x] PR title and commit messages follow conventional commit syntax
[ ] If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: 55fe36b7628a3e222b43815df1d373085e98a7b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR