chore(sto-bro): remove unused createStorageBrowser dir

aws-amplify / amplify-ui

Amplify UI is a collection of accessible, themeable, performant React (and more!) components that can connect directly to the cloud.

https://ui.docs.amplify.aws

Apache License 2.0

913 stars 295 forks source link

chore(sto-bro): remove unused createStorageBrowser dir #6117

Closed calebpollman closed 1 week ago

calebpollman commented 1 week ago

Description of changes

Delete unused createStorageBrowser dir and duplicated types

Issue #, if available

Description of how you validated changes

Checklist

[ ] Have read the Pull Request Guidelines
[ ] PR description included
[ ] yarn test passes and tests are updated/added
[ ] PR title and commit messages follow conventional commit syntax
[ ] If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 6b36cc6b072a45644daa112261a3b830457424c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mrazauskas commented 4 days ago

@calebpollman @HuiSF It seems like after this change jest-tsd and @tsd/typescript can be also removed:

https://github.com/aws-amplify/amplify-ui/blob/a68d8f76aeb766000a9c231196d6b249f1bba1ab/packages/react-storage/package.json#L61-L62

These dependencies were added in #5907. That PR was adding some type tests, but these are removed by this PR.

I wanted to open a PR, but cloning the repo and running yarn fails. I tried yarn install --ignore-engines, but that also failed to update the lock file. So just wanted to draw your attention.