aws-amplify / amplify-ui

Amplify UI is a collection of accessible, themeable, performant React (and more!) components that can connect directly to the cloud.
https://ui.docs.amplify.aws
Apache License 2.0
913 stars 295 forks source link

fix: missing elevated card shadow on dark mode #6185

Open tiffanynwyeung opened 1 day ago

tiffanynwyeung commented 1 day ago

Description of changes

This change fixes missing box shadows on the elevated variation of the Card component. This is because dark mode shadow colors are not defined so it defaults to the light mode shadows, which are extremely difficult to spot in dark mode.

This change also visually changes/affects the dark mode versions of other components that use box shadows in general: Authenticator, Menu, and Slider Field.

Before After
Card Card
Authenticator Authenticator
Menu Menu
Slider Field (thumb) Slider Field (thumb)

Issue #, if available

Fixes #5893.

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 day ago

🦋 Changeset detected

Latest commit: fe9458f94576678a3b9bf31bfb63d5e11a53db8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages | Name | Type | | ---------------------------------------- | ----- | | @aws-amplify/ui | Patch | | @aws-amplify/ui-react-auth | Patch | | @aws-amplify/ui-react-core-auth | Patch | | @aws-amplify/ui-react-core-notifications | Patch | | @aws-amplify/ui-react-core | Patch | | @aws-amplify/ui-react-liveness | Patch | | @aws-amplify/ui-react-native-auth | Patch | | @aws-amplify/ui-react-native | Patch | | @aws-amplify/ui-react-notifications | Patch | | @aws-amplify/ui-react-storage | Patch | | @aws-amplify/ui-react | Patch | | @aws-amplify/ui-vue | Patch | | @aws-amplify/ui-angular | Patch | | @aws-amplify/ui-react-geo | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR