fix(react-storage): default nullish progress to 100% if status is "complete" - Githubissues

aws-amplify / amplify-ui

Amplify UI is a collection of accessible, themeable, performant React (and more!) components that can connect directly to the cloud.

https://ui.docs.amplify.aws

Apache License 2.0

913 stars 295 forks source link

fix(react-storage): default nullish progress to 100% if status is "complete" #6186

Open jordanvn opened 1 day ago

jordanvn commented 1 day ago

Description of changes

In storage browser actions where progress is not defined yet there is a COMPLETE status (such as uploading a zero-byte file), default to setting the progress to 100% instead of 0%

Issue #, if available

Description of how you validated changes

Checklist

[ ] Have read the Pull Request Guidelines
[ ] PR description included
[ ] yarn test passes and tests are updated/added
[ ] PR title and commit messages follow conventional commit syntax
[ ] If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 day ago

⚠️ No Changeset found

Latest commit: 2a0b65a9f1d7586307cfd33c3a782d58e0093c46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR