chore(storage-browser): Update control unit tests to be more isolated - Githubissues

aws-amplify / amplify-ui

Amplify UI is a collection of accessible, themeable, performant React (and more!) components that can connect directly to the cloud.

https://ui.docs.amplify.aws

Apache License 2.0

913 stars 295 forks source link

chore(storage-browser): Update control unit tests to be more isolated #6194

Open cshfang opened 8 hours ago

cshfang commented 8 hours ago

Description of changes

This PR streamlines the control unit tests to isolate its mocks a bit better so that it is not implicitly testing upstream dependent components

Issue #, if available

Description of how you validated changes

Checklist

[ ] Have read the Pull Request Guidelines
[ ] PR description included
[ ] yarn test passes and tests are updated/added
[ ] PR title and commit messages follow conventional commit syntax
[ ] If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 8 hours ago

⚠️ No Changeset found

Latest commit: 5da267085230d48d81858b18313f2e6bb84fb50e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR