search

aws-amplify / aws-sdk-ios

AWS SDK for iOS. For more information, see our web site:
https://aws-amplify.github.io/docs
Other
1.68k stars 885 forks source link

Binary XCFrameworks do not contain debug symbols #3562

Closed ffittschen closed 3 years ago

ffittschen commented 3 years ago

Describe the bug The binary xcframeworks distributed with Swift Package Manager via https://github.com/aws-amplify/aws-sdk-ios-spm do not contain any debug symbols.

To Reproduce Steps to reproduce the behavior:

  1. Integrate any target of the AWS SDK into an app that uses some crash reporter, such as Visual Studio AppCenter
  2. Trigger a crash within the AWS SDK
  3. Look at the crash logs in the crash reporter
  4. See the hidden stack traces

Observed Behavior The stack traces are not desymbolicated, which makes them useless.

Expected Behavior I'd expect that the binary xcframeworks contain dSYMs (and bitcode) since this is supported since Xcode 12.

Stack Trace

Thread 10 Crashed:
0   CoreFoundation                       0x000000019689cb38 0x196868000 + 215864
1   CoreFoundation                       0x0000000196921df0 0x196868000 + 761328
2   AWSIoT                               0x0000000107b13118 _hidden#41_ (__hidden#478_:650)
3   AWSIoT                               0x0000000107b16d34 _hidden#79_ (__hidden#478_:1232)
4   AWSIoT                               0x0000000107b8cea0 _hidden#15137_ (__hidden#15366_:1610)
5   libdispatch.dylib                    0x000000019658024c 0x19657e000 + 8780
6   libdispatch.dylib                    0x0000000196581db0 0x19657e000 + 15792
7   libdispatch.dylib                    0x0000000196592a68 0x19657e000 + 84584
8   libdispatch.dylib                    0x0000000196593120 0x19657e000 + 86304
9   libsystem_pthread.dylib              0x00000001e24397d8 0x1e2436000 + 14296
10  libsystem_pthread.dylib              0x00000001e244076c 0x1e2436000 + 42860

Screenshots

Screen Shot 2021-04-28 at 10 44 22@2x

Environment(please complete the following information):

Additional context We integrated AWSIoT and AWSCore according to the README-spm-support.md file.

brennanMKE commented 3 years ago

Updated CircleCi script to include debug files and confirmed with FileMerge between the output before and after the update.

XCF-Debug
github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 14 days with no activity. Please, provide an update or it will be automatically closed in 7 days.

github-actions[bot] commented 3 years ago

This issue is being automatically closed due to inactivity. If you believe it was closed by mistake, provide an update and re-open it.

diegocstn commented 3 years ago

dSYMs are included in binary XCFrameworks since version v2.24.3 of the SDKs.