aws-amplify / aws-sdk-ios

AWS SDK for iOS. For more information, see our web site:
https://aws-amplify.github.io/docs
Other
1.68k stars 885 forks source link

Eliminate Dispatch Semaphore in MQTT internal code #4210

Closed brennanMKE closed 2 years ago

brennanMKE commented 2 years ago

Which AWS Services is the feature request for?

AWSIoT

Is your feature request related to a problem? Please describe.

Dispatch Semaphore is being used in 3 places to protect state in stored properties. Serial behavior can be achieved with a Dispatch Queue instead which won't experience some of the problems which have been caused by the use of semaphores.

Describe the solution you'd like

In every block of code where serial behavior is necessary, a block for a Dispatch Queue will be used.

Related

https://github.com/aws-amplify/aws-sdk-ios/issues/2016

brennanMKE commented 2 years ago

PR is merged