search

aws-amplify / aws-sdk-ios

AWS SDK for iOS. For more information, see our web site:
https://aws-amplify.github.io/docs
Other
1.68k stars 885 forks source link

AWSMobileHubHelper SDK closure (AnyObject, NSError) -> Void, Which should be (AnyObject?, NSError?) -> Void . #440

Closed beeth0ven closed 8 years ago

beeth0ven commented 8 years ago

In AWSMobileHubHelper's protocol AWSSignInProvider , There is a function:

public func login(completionHandler: (AnyObject, NSError) -> Void)

I think the parameters it should be optional type like this:

public func login(completionHandler: (AnyObject?, NSError?) -> Void)

2016-08-07 11 40 03

I think this is the same kind of issue with this one:

NSError is imported as non-optional in swift in didCompletePasswordAuthenticationStepWithError

karthiksaligrama commented 8 years ago

fixed. You can find the mobile hub code in this repo aws/aws-mobilehub-helper-ios