aws-amplify / maplibre-gl-js-amplify

Apache License 2.0

14 stars 10 forks source link

fix: append query params to existing query params if any #203

Closed sreeramsama closed 1 year ago

sreeramsama commented 1 year ago

Description of changes

Append query params to existing query params if any

Issue #, if available

Maplibre will parse the urls defined in the style-descriptor file and fetch the tiles. However, in the transform function, query params were added to url starting with x-amz-user-agent as the first param. This is an issue when the input url already has a query param. With the fix, x-amz-user-agent is appended to existing query params.

Description of how you validated changes

Tested with raster tiles fetched from style descriptor

Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are [changed or added]
[ ] Relevant documentation is changed or added (and PR referenced)

codecov-commenter commented 1 year ago

Codecov Report

Merging #203 (f7b1bfc) into main (8d80cbd) will increase coverage by 0.04%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   43.79%   43.83%   +0.04%     
==========================================
  Files          16       16              
  Lines        1265     1266       +1     
  Branches      200      201       +1     
==========================================
+ Hits          554      555       +1     
  Misses        711      711

Impacted Files	Coverage Δ
src/AmplifyMapLibreRequest.ts	`85.71% <ø> (+0.20%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.0-unstable.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.0-geo.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: