aws-amplify / maplibre-gl-js-amplify

Apache License 2.0
14 stars 10 forks source link

chore: Set up integ tests on gh actions #229

Closed thaddmt closed 1 year ago

thaddmt commented 1 year ago

Description of changes

FILE => publish.yml

FILE => codeql.yml WARN check_for_non_github_managed_actions

FILE => callable-e2e-test.yml WARN check_for_upload_download_artifact_action WARN check_for_inline_script WARN check_for_non_github_managed_actions

FILE => callable-e2e-tests.yml

Summary The following Actions failed to pass one or more checks: • .github/workflows/coverage.yml • .github/workflows/codeql.yml • .github/workflows/callable-e2e-test.yml


  - [x] Update the environment secret to use a PAT from our amplify-ui-automation account (currently using my personal one only for testing)

<!--
Thank you for your Pull Request! Please provide a description above and review
the requirements below.
-->

#### Issue #, if available

<!-- Also, please reference any associated PRs for documentation updates. -->

#### Description of how you validated changes

#### Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] PR description included
- [ ] `yarn test` passes
- [ ] Tests are [changed or added]
- [ ] Relevant documentation is changed or added (and PR referenced)

<!-- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. -->
codecov-commenter commented 1 year ago

Codecov Report

Merging #229 (2bb3334) into main (0e359a8) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   43.99%   43.99%           
=======================================
  Files          16       16           
  Lines        1273     1273           
  Branches      201      201           
=======================================
  Hits          560      560           
  Misses        713      713           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

stocaaro commented 1 year ago

Ghast looks really cool. We received feedback from AppSec to do static analysis on a few security areas, which I added as a JS script. We might be able to replace this with Ghast, but I think we would need security review for this tool before turning it on.

Don't see anything concerning here. Has this work been through security review yet?

thaddmt commented 1 year ago

Ghast looks really cool. We received feedback from AppSec to do static analysis on a few security areas, which I added as a JS script. We might be able to replace this with Ghast, but I think we would need security review for this tool before turning it on.

Don't see anything concerning here. Has this work been through security review yet?

I actually received a recommendation to use this tool from appsec!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.0-geo.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.0-unstable.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 4.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: