Closed onno-vos-dev closed 6 months ago
This is very cool. Thank you for all of your efforts
This would be the diff in aws-elixir
when ignoring all doc
-strings.
Using the following git grep
we can exclude some of the expected diffs and we're left with 251 lines difference:
git diff | grep "^-\|^+" | grep -v "200\|nil\|lib/aws/generated\|abbreviation\|signing_name\|target_prefix\|url_path\|^-[[:space:]]*\"\|^+[[:space:]]*\"\|^-$\|^+$" | wc -l
251
Looking at that actual diff we end up with: aws-elixir-actual-diff.patch
Here we see mostly some new/removed functions in control_tower | entity_resolution | neptunedata | q_business | s3
. Ignoring those and repeating the above git diff
, we're left with 39 lines changed 🎉 Quite impressive considering the specs have changed as massively as they did 👍
This would be the diff in aws-erlang
when ignoring all doc
-strings.
Using the following git grep
we can exclude some of the expected diffs and we're left with 212 lines difference:
git diff | grep -v "src/aws_\|%%\|SuccessStatusCode\|Path = \|send_body_as_binary\|receive_body_as_binary\|Options0\|Options2\|proplists_take\|proplists:get_value\|proplists:delete\|^+$\|^-$\|QueryMap\|Client#{" | grep '^[+-]' | wc -l
212
Looking at that actual diff we end up with: aws-erlang-actual-diff.patch
Here we see mostly some new/removed functions in control_tower | entity_resolution | neptunedata | q_business | s3
. Ignoring those and repeating the above git diff
, we're left with 46 lines changed 🎉 Quite impressive considering the specs have changed as massively as they did 👍
Goal here has been to minimize the diff in aws-elixir and aws-erlang to a bare minimum.
Some minor diffs were unavoidable and deemed acceptable
Fix SuccessStatusCode to always be 200 if not provided by AWS in the API
Fix aws-erlang/issues/148 to allow send_body_as_binary & receive_body_as_binary to be sent in as options
Drop abbreviation from metadata. It is no longer available in aws-sdk-go-v2 and unused in aws-elixir
Slight formatting changes on aws-erlang docs as the new docs contain a lot more newlines and hence cause more noise
Uri Paths may have changed. This should not impact the clients. It was likely broken in the aws-sdk-go
QueryMap may have changed but should not impact the client. It was likely broken in the aws-sdk-go
Docs have changed (massively) since almost all documentation has been updated
[x] Update aws-elixir pipeline to use the new aws-sdk-go-v2 for it's nightly builds
[x] Update aws-erlang pipeline to use the new aws-sdk-go-v2 for it's nightly builds
This has been quite an effort and I just wanna say thank you to Amin, Gustavo and Philip for their contribution, reviews and ideas! 🙇 ❤️ I added each of you as Co-Authors to the commit so you'll get your contribution in the stats! ❤️