aws-beam / aws-codegen

Code generator for AWS clients in Erlang and Elixir.
Other
53 stars 49 forks source link

Add identifier to reserved types and fix reserved_type references to use correct reference rather than ghost-type #115

Closed onno-vos-dev closed 2 months ago

onno-vos-dev commented 2 months ago

This broke the AWS-Erlang & AWS-Elixir nightly builds which went unnoticed.

Example:

%% Example:
%% quicksight_identifier() :: #{
%%   <<"Identity">> => string()
%% }
-type quicksight_identifier() :: #{binary() => any()}.

%% Example:
%% topic_sort_clause() :: #{
%%   <<"Operand">> => quicksight_identifier(),
%%   <<"SortDirection">> => list(any())
%% }
-type topic_sort_clause() :: #{binary() => any()}.
  @typedoc """

  ## Example:

      quicksight_identifier() :: %{
        "Identity" => String.t()
      }

  """
  @type quicksight_identifier() :: %{String.t() => any()}

  @typedoc """

  ## Example:

      topic_sort_clause() :: %{
        "Operand" => quicksight_identifier(),
        "SortDirection" => list(any())
      }

  """
  @type topic_sort_clause() :: %{String.t() => any()}
onno-vos-dev commented 2 months ago

I think this can close #114 , right?

Thank you @onno-vos-dev!

Yes it can! Somehow I missed that issue 🙈 I blame summer vacation...