Addl modules - Githubissues

aws-beam / aws-codegen

Code generator for AWS clients in Erlang and Elixir.

Other

53 stars 49 forks source link

Addl modules #6

Closed jadeallenx closed 4 years ago

jadeallenx commented 4 years ago

Problems to solve:

jsx has been deprecated for years
need secrets manager client base

Solutions:

use jsone for JSON encoding/decoding
add secrets manager to the list of modules to generate

jfacorro commented 4 years ago

@mrallen1 I'm going over the open PRs and I was wondering what makes you say that "jsx has been deprecated for years". It looks like it's still being maintained and there are quite a few recent releases for it in hex.pm.

jadeallenx commented 4 years ago

It had been the case for a long time. In any case, I just prefer jsone 🤷

jfacorro commented 4 years ago

I can add support for the Secrets Manager API in a new PR. Would you be willing to keep jsx since that is what is currently being used and seems to work? If so, can I close this PR? 😄 🙏

jadeallenx commented 4 years ago

I guess so. Still prefer jsone though.

jfacorro commented 4 years ago

Secrets Manager API is now added #18. 😄

I will close this PR and we can discuss migrating to jsone in #19.