aws-beam / aws-codegen

Code generator for AWS clients in Erlang and Elixir.
Other
53 stars 49 forks source link

[#67] Do not decode binary response body #68

Closed robertoaloi closed 3 years ago

robertoaloi commented 3 years ago

Emulating the approach in #62 , this PR skips decoding of the response body for those methods where the body is a binary. Since my Elixir knowledge is quite limited, please advise on the change for the Elixir generated code (currently not included in this PR).

robertoaloi commented 3 years ago

I think the Elixir version requires the update of the AWS.Request module:

Let me know if you would like me to also check the Elixir parts or if you prefer tackling that yourself. I'm new to Elixir, so that's the slowest part for me...

robertoaloi commented 3 years ago

Let me know if you would like me to also check the Elixir parts or if you prefer tackling that yourself. I'm new to Elixir, so that's the slowest part for me...

Created #71 for the Elixir part, not to be blocked on the Erlang side. I will try to address it, but if you want to jump in you're welcome!