search

aws-beam / aws-codegen

Code generator for AWS clients in Erlang and Elixir.
Other
53 stars 49 forks source link

generate structs for post services #87

Closed andyleclair closed 8 months ago

andyleclair commented 2 years ago

This code will generate all of the internal modules that are defined by the shapes in the api json. I wouldn't merge this, it takes forever to compile, however, it might be a good starting point for generating input/output types.

andyleclair commented 2 years ago

Oh, I ran this and it did pass dialyzer in aws-elixir!

onno-vos-dev commented 8 months ago

@andyleclair Sorry to see this PR never got a reply. Can you clarify what the use-case for all these additional structs would be? I'd love to hear what this would be used for and if useful, I'm happy to include something like this 👍

I'm happy to take a look at this as we're moving to the https://github.com/aws/aws-sdk-go-v2 (behind the scenes) so this might be worth picking up by myself and a colleague who're performing that migration on the back.

andyleclair commented 8 months ago

@onno-vos-dev I've moved on from the project I was working on w/r/t this code, but my idea here was to support the POST type services that AWS has better by adding the input and output shape. In order to do that I created the shapes struct so the output would be not just bare maps and provide some LSP help. Happy to help if you all need, but tbh I have a baby now and my availability for this particular lark is probably less than it would've been in 2022 😅

onno-vos-dev commented 8 months ago

@andyleclair Congrats on the baby! 👶 Thank you for getting back to me!

I'll throw it on my radar to take a look at :-) It'd definitely be nice to avoid the Input map and having to manually look up the API specs to figure out what should be in Input which has personally bothered me for a while 😅

I'll pick up your work and have a pokey-poke 👍 If possible, I might try to integrate it into the v2 code generator 👍

onno-vos-dev commented 8 months ago

Closing this PR.

I have a branch where I've ported this over to the new aws-sdk-go-v2 but as you said yourself: "it takes forever to compile". I'm currently trying to figure out how best to proceed with this and we'll likely start by simply including some additional information in the @doc to start with. TBC 👍