search

aws-beam / aws-codegen

Code generator for AWS clients in Erlang and Elixir.
Other
53 stars 49 forks source link

Include action on REST calls #90

Open andrewhr opened 1 year ago

andrewhr commented 1 year ago

This extra bit of information is useful in the context of telemetry, specifically OpenTelemetry, as it allow us to adhere to Semantic Attributes for AWS.

To reduce coordination efforts, this change will only affect aws-elixir. A further patch can address aws-erlang to achieve parity.

andrewhr commented 1 year ago

Worth noting this PR is a bit old, done when ServiceMetadata struct was a thing. Given metadata is now just a plain Map, an alternative is to include the action_name as part of the metadata.

onno-vos-dev commented 8 months ago

@andrewhr Sorry to dig this up as this seems to have fallen between chairs. Any chance you can rebase and pick this up so we can get it back into a mergeable state? 👍