search

aws-cloudformation / aws-cloudformation-resource-providers-acmpca

CloudFormation Resource Provider for the Amazon Certificate Manager Private Certificate Authority (ACM-PCA) Service.
Apache License 2.0
3 stars 4 forks source link

Maven build failing #3

Open PatMyron opened 3 years ago

PatMyron commented 3 years ago

due to only updating internal Brazil Config file(s) without also updating external Maven pom.xml file(s):

$ grep -L 'software.amazon.awssdk' */*/pom.xml # SDK missing from Maven dependencies
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificate/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthority/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthorityactivation/pom.xml # just a different Maven namespace

aws-cloudformation-resource-providers-cloudformation/aws-cloudformation-moduleversion/pom.xml
aws-cloudformation-resource-providers-ec2-cagw/aws-ec2-carriergateway/pom.xml
aws-cloudformation-resource-providers-ec2-prefix-list/aws-ec2-prefixlist/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-accelerator/pom.xml
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-endpointgroup/pom.xml
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-listener/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-authorizer/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-certificate/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-provisioningtemplate/pom.xml
aws-cloudformation-resource-providers-rds-proxy/aws-rds-dbproxy/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-rds-proxy/aws-rds-dbproxytargetgroup/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-timestream/aws-timestream-database/pom.xml
aws-cloudformation-resource-providers-timestream/aws-timestream-table/pom.xml

due to deprecated aws-cloudformation-rpdk-java-plugin version:

$ grep -A 1 'aws-cloudformation-rpdk-java-plugin' */*/pom.xml | grep -B 1 '>1\.' # deprecated aws-cloudformation-rpdk-java-plugin v1
aws-cloudformation-resource-providers-accessanalyzer/aws-accessanalyzer-analyzer/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-accessanalyzer/aws-accessanalyzer-analyzer/pom.xml-            <version>1.0.1</version>
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificate/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificate/pom.xml-            <version>1.0</version>
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthority/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthority/pom.xml-            <version>1.0</version>
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthorityactivation/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthorityactivation/pom.xml-            <version>1.0</version>

aws-cloudformation-resource-providers-ec2-flowlog/aws-ec2-flowlog/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-ec2-flowlog/aws-ec2-flowlog/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-ec2-prefix-list/aws-ec2-prefixlist/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-ec2-prefix-list/aws-ec2-prefixlist/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-imagebuilder/component/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-imagebuilder/component/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-imagebuilder/distribution-configuration/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-imagebuilder/distribution-configuration/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-imagebuilder/image-pipeline/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-imagebuilder/image-pipeline/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-imagebuilder/image-recipe/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-imagebuilder/image-recipe/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-imagebuilder/image/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-imagebuilder/image/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-imagebuilder/infrastructure-configuration/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-imagebuilder/infrastructure-configuration/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-opsworkscm/aws-opsworkscm-server/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-opsworkscm/aws-opsworkscm-server/pom.xml-            <version>1.0.5</version>
aws-cloudformation-resource-providers-ses/aws-ses-configurationset/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-ses/aws-ses-configurationset/pom.xml-            <version>1.0.2</version>
aws-cloudformation-resource-providers-ssm/aws-ssm-patchbaseline/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-ssm/aws-ssm-patchbaseline/pom.xml-            <version>1.0</version>
aws-cloudformation-resource-providers-ssm/aws-ssm-resourcedatasync/pom.xml:            <artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
aws-cloudformation-resource-providers-ssm/aws-ssm-resourcedatasync/pom.xml-            <version>1.0.2</version>

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-acmpca/blob/e3c591cddff371786b4dacaaef1d02b938b121c7/aws-acmpca-certificate/pom.xml#L30-L34

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-acmpca/blob/e3c591cddff371786b4dacaaef1d02b938b121c7/aws-acmpca-certificateauthority/pom.xml#L30-L34

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-acmpca/blob/e3c591cddff371786b4dacaaef1d02b938b121c7/aws-acmpca-certificateauthorityactivation/pom.xml#L30-L34

https://w.amazon.com/bin/view/AWS21/Design/Uluru/V2/Upgrade_Guide

PatMyron commented 3 years ago

actually might just be using a different Maven namespace than software.amazon.awssdk for that top half: https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-acmpca/blob/e3c591cddff371786b4dacaaef1d02b938b121c7/aws-acmpca-certificate/pom.xml#L71-L76 https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-acmpca/blob/e3c591cddff371786b4dacaaef1d02b938b121c7/aws-acmpca-certificateauthority/pom.xml#L71-L75 https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-acmpca/blob/e3c591cddff371786b4dacaaef1d02b938b121c7/aws-acmpca-certificateauthorityactivation/pom.xml#L71-L76