search

aws-cloudformation / aws-cloudformation-resource-providers-awsutilities-commandrunner

Apache License 2.0
81 stars 21 forks source link

Incorrect logical resource name in some README examples #61

Closed pbrisbin closed 6 months ago

pbrisbin commented 10 months ago

The README shows the following differences among its code blocks:

First form (2 occurrences):

Resources:
  CommandRunner: # <-- NOTE
    # ...

Outputs:
  Output:
    Value: !GetAtt "Command.Output"

Second form (4 occurrences):

Resources:
  Command:
    # ...

Outputs:
  Output:
    Value: !GetAtt "Command.Output"

I'm 99% sure that for !GetAtt "Command.Output" to work, the resource must be logically named Command (second form), not CommandRunner (first form). But there's a lot of magic here, so I may be missing something.

Which is correct?

shantgup commented 6 months ago

Fixed!