aws-cloudformation / aws-cloudformation-resource-providers-cloudformation

The CloudFormation Resource Provider Package For AWS CloudFormation
https://aws.amazon.com/cloudformation/
Apache License 2.0
48 stars 35 forks source link

[ModuleVersion] Return empty string instead of null for DocumentationUrl #108

Closed MalikAtalla-AWS closed 1 year ago

MalikAtalla-AWS commented 1 year ago

Description of changes: I made a mistake in my last PR. I can't remove DocumentationUrl from the readOnlyProperties, because that would enable users to specify it in the template which is not how the attribute is intended to be used. The contract tests are complaining that we're not always returning the documentationUrl. Removing it would be backwards-incompatible, so to adhere to the resource type contract we'll return an empty string when the module doesn't have a documentationUrl.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.