search

aws-cloudformation / aws-cloudformation-resource-providers-cloudformation

The CloudFormation Resource Provider Package For AWS CloudFormation
https://aws.amazon.com/cloudformation/
Apache License 2.0
48 stars 35 forks source link

Improve Error Message on Stackset Resource #17

Closed ConnorKirk closed 4 years ago

ConnorKirk commented 4 years ago

Hi!

When trying out the AWS::CloudFormation::Stackset resource, my deployment fails.

The error is my fault. I believe the error message could be improved. My understanding of the error message is that the Stackset resource does not match the schema definition. In this case, two required properties were missing. I would appreciate a more informative explanation of where it is wrong, as other resources provide.

image

If possible, could you improve the error message returned by the resource in this scenario?

PatMyron commented 4 years ago

Agreed, but I actually think this shouldn't be solved at the resource provider level I believe this is a CloudFormation platform wide issue with resource schema validation messages, especially combined schemas

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-cloudformation/blob/252695dbb90947fc70ced571e6ec983a50495c1c/aws-cloudformation-stackset/aws-cloudformation-stackset.json#L273-L288

ConnorKirk commented 4 years ago

Interesting, thanks Pat! I guess this isn't a change I can make a PR for then 😢 I'll close this issue for now.