Closed xiwhuang closed 4 years ago
any way to scope this down a little more into separate PRs?
Having one for the auto generated code, then the schema, then maybe individual handlers will let us as reviewers more readily give feedback
any way to scope this down a little more into separate PRs?
Having one for the auto generated code, then the schema, then maybe individual handlers will let us as reviewers more readily give feedback
any way to scope this down a little more into separate PRs?
Having one for the auto generated code, then the schema, then maybe individual handlers will let us as reviewers more readily give feedback
It is not easy to start it over though, But I think it is a very good suggestion, maybe we should make it as a documented PR standard and let everyone follow.
Reviewed the StackSets logics are fine.
Great work! Is there a timeframe for bringing this to official CloudFormation (e.g. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.html)?
It might also be useful to change the state in the coverage roadmap: https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/102
Additionally is their work planned for having separate StackInstance resources? I can see value in being able to define the StackSet in one Stack and StackInstances in another (https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/103).
Description of changes:
Added new resource AWS::CloudFormation::StackSet
Lastest Revision:
AwsCredentialsExtrator
as it is no longer needed.Testing
Unit Tests
Manually tests
CREATE
/DELETE
/UPDATE
CREATE
/DELETE
/UPDATE
TemplateURL
/TemplateBody
Invalid Template
TemplateURL
/TemplateBody
Known limitation
TemplateURL
andOrganizationUnitIds
can be not retrieve in READ/LIST handlers as StackSet API currently does not allow to do so.Simple Working Template
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.