aws-cloudformation / aws-cloudformation-resource-providers-cloudformation

The CloudFormation Resource Provider Package For AWS CloudFormation
https://aws.amazon.com/cloudformation/
Apache License 2.0
48 stars 35 forks source link

Add Stackset Resource #6

Closed xiwhuang closed 4 years ago

xiwhuang commented 4 years ago

Description of changes:

Added new resource AWS::CloudFormation::StackSet

Lastest Revision:

Testing

Unit Tests

Known limitation

Simple Working Template

Resources:
  MyStackSet:
    Type: AWS::CloudFormation::StackSet
    Properties:
      PermissionModel: SELF_MANAGED
      TemplateBody: |
        {
          "AWSTemplateFormatVersion": "2010-09-09",
          "Resources": {
            "IntegrationTestWaitHandle": {
              "Type": "AWS::CloudFormation::WaitConditionHandle",
              "Properties": {}
            }
          }
        }
      StackInstancesGroup: 
        - Regions:
            - us-east-1
            - us-west-2
          DeploymentTargets:
            Accounts:
              - 111111111111
      Tags:
        - Key: key1
          Value: value1
Outputs:
  StackSetId:
    Value: !Ref MyStackSet

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

johnttompkins commented 4 years ago

any way to scope this down a little more into separate PRs?

Having one for the auto generated code, then the schema, then maybe individual handlers will let us as reviewers more readily give feedback

ammokhov commented 4 years ago

any way to scope this down a little more into separate PRs?

Having one for the auto generated code, then the schema, then maybe individual handlers will let us as reviewers more readily give feedback

xiwhuang commented 4 years ago

any way to scope this down a little more into separate PRs?

Having one for the auto generated code, then the schema, then maybe individual handlers will let us as reviewers more readily give feedback

It is not easy to start it over though, But I think it is a very good suggestion, maybe we should make it as a documented PR standard and let everyone follow.

guanghug commented 4 years ago

Reviewed the StackSets logics are fine.

s0enke commented 4 years ago

Great work! Is there a timeframe for bringing this to official CloudFormation (e.g. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.html)?

benbridts commented 4 years ago

It might also be useful to change the state in the coverage roadmap: https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/102

Additionally is their work planned for having separate StackInstance resources? I can see value in being able to define the StackSet in one Stack and StackInstances in another (https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/103).