aws-cloudformation / aws-cloudformation-resource-providers-codeartifact

The CloudFormation Resource Provider Package for the AWS CodeArtifact service
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/AWS_CodeArtifact.html
Apache License 2.0
27 stars 7 forks source link

Fixing some of the contract tests for Domain. #22

Closed jonjara closed 4 years ago

jonjara commented 4 years ago

Issue #, if available:

Description of changes: Adding in some fixes that make the handlers to adhere to https://docs.aws.amazon.com/cloudformation-cli/latest/userguide/resource-type-test-contract.html.

contract_invalid_create still doesn't pass and I am going to reach out to CloudFormation to get guidance on this test

NOTES:

Testing

handler_create.py::contract_create_delete PASSED                         [  6%]
handler_create.py::contract_invalid_create PASSED                        [ 12%]
handler_create.py::contract_create_duplicate SKIPPED                     [ 18%]
handler_create.py::contract_create_read_success PASSED                   [ 25%]
handler_create.py::contract_create_list_success PASSED                   [ 31%]
handler_delete.py::contract_delete_read PASSED                           [ 37%]
handler_delete.py::contract_delete_list PASSED                           [ 43%]
handler_delete.py::contract_delete_update PASSED                         [ 50%]
handler_delete.py::contract_delete_delete PASSED                         [ 56%]
handler_delete.py::contract_delete_create SKIPPED                        [ 62%]
handler_misc.py::contract_check_asserts_work PASSED                      [ 68%]
handler_read.py::contract_read_without_create PASSED                     [ 75%]
handler_update.py::contract_update_read_success PASSED                   [ 81%]
handler_update.py::contract_update_list_success PASSED                   [ 87%]
handler_update_invalid.py::contract_update_create_only_property PASSED   [ 93%]
handler_update_invalid.py::contract_update_non_existent_resource PASSED  [100%]

When I run the tests that ERROR by themselves they pass

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.