aws-cloudformation / aws-cloudformation-resource-providers-codeartifact

The CloudFormation Resource Provider Package for the AWS CodeArtifact service
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/AWS_CodeArtifact.html
Apache License 2.0
27 stars 7 forks source link

Example JSON is incorrect #34

Closed jonjara closed 3 years ago

jonjara commented 3 years ago

Describe the issue Sample template with ExternalConnection is incorrect

To Reproduce Steps to reproduce the behavior: Take this sample template: https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-codeartifact/blob/main/sample-templates/json/create-repository-with-external-connection.json and the stack creation will fail

ExternalConnection should be ExternalConnections

Screenshots or logs If applicable, add screenshots or logs to help explain your problem.

sankalpbhandari commented 3 years ago

Closing this issue as sample template is fixed as part of https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-codeartifact/pull/35