aws-cloudformation / aws-cloudformation-resource-providers-codeartifact

The CloudFormation Resource Provider Package for the AWS CodeArtifact service
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/AWS_CodeArtifact.html
Apache License 2.0
27 stars 7 forks source link

Property descriptions are backwards #4

Closed richardhboyd closed 3 years ago

richardhboyd commented 3 years ago
    "AssetSizeBytes": {
      "description": "The current status of a domain. The valid values are",
      "type": "integer"
    },
    "Status": {
      "description": "The total size of all assets in the domain.",
      "pattern": "/^(Active|Deleted)$/",
      "type": "string"
    },

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-codeartifact/blob/master/aws-codeartifact-domain/aws-codeartifact-domain.json#L30-L37

Also, 'integer' for number of bytes in a domain feels like an integer overflow waiting to happen. What happens after 2.1GB?

detam-amazon commented 3 years ago

Description was fixed by Ian, but a response to the integer comment by Richard is still needed.

detam-amazon commented 3 years ago

AssetSizeBytes was removed, so no longer an issue