aws-cloudformation / aws-cloudformation-resource-providers-codeartifact

The CloudFormation Resource Provider Package for the AWS CodeArtifact service
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/AWS_CodeArtifact.html
Apache License 2.0
27 stars 7 forks source link

Fixing contract tests for AWS::CodeArtifact::Domain Repository after … #44

Closed jonjara closed 3 years ago

jonjara commented 3 years ago

Schema got changed so we need to fix this contract tests.

        .repositoryName(repositoryDescription.name())
        .name(repositoryDescription.name());

In my previous PR I decided we didn't need that but this threw the contract tests out of whack so I'm adding them back in

➜  aws-codeartifact-domain git:(main) ✗ cfn test --enforce-timeout 240
=========================================================================================== test session starts ============================================================================================
platform darwin -- Python 3.7.8, pytest-5.4.3, py-1.9.0, pluggy-0.13.1 -- /usr/local/opt/python@3.7/bin/python3.7
cachedir: .pytest_cache
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Volumes/Unix/workplace/aws-cloudformation-resource-providers-codeartifact/aws-codeartifact-domain/.hypothesis/examples')
rootdir: /Volumes/Unix/workplace/aws-cloudformation-resource-providers-codeartifact/aws-codeartifact-domain, inifile: /private/var/folders/n_/7tmz09ds2gv06hqgr5ry6sr8n8z_lw/T/pytest_rwp64i7e.ini
plugins: localserver-0.5.0, random-order-1.0.4, hypothesis-5.19.2
collected 16 items

handler_create.py::contract_create_delete PASSED                                                                                                                                                     [  6%]
handler_create.py::contract_invalid_create PASSED                                                                                                                                                    [ 12%]
handler_create.py::contract_create_duplicate SKIPPED                                                                                                                                                 [ 18%]
handler_create.py::contract_create_read_success PASSED                                                                                                                                               [ 25%]
handler_create.py::contract_create_list_success PASSED                                                                                                                                               [ 31%]
handler_delete.py::contract_delete_read PASSED                                                                                                                                                       [ 37%]
handler_delete.py::contract_delete_list PASSED                                                                                                                                                       [ 43%]
handler_delete.py::contract_delete_update PASSED                                                                                                                                                     [ 50%]
handler_delete.py::contract_delete_delete PASSED                                                                                                                                                     [ 56%]
handler_delete.py::contract_delete_create SKIPPED                                                                                                                                                    [ 62%]
handler_misc.py::contract_check_asserts_work PASSED                                                                                                                                                  [ 68%]
handler_read.py::contract_read_without_create PASSED                                                                                                                                                 [ 75%]
handler_update.py::contract_update_read_success PASSED                                                                                                                                               [ 81%]
handler_update.py::contract_update_list_success PASSED                                                                                                                                               [ 87%]
handler_update_invalid.py::contract_update_create_only_property PASSED                                                                                                                               [ 93%]
handler_update_invalid.py::contract_update_non_existent_resource PASSED                                                                                                                              [100%]

================================================================================ 14 passed, 2 skipped in 1521.39s (0:25:21) ================================================================================

➜  aws-codeartifact-repository git:(main) ✗ cfn test --enforce-timeout 240
============================================================================================================== test session starts ===============================================================================================================
platform darwin -- Python 3.7.8, pytest-5.4.3, py-1.9.0, pluggy-0.13.1 -- /usr/local/opt/python@3.7/bin/python3.7
cachedir: .pytest_cache
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Volumes/Unix/workplace/aws-cloudformation-resource-providers-codeartifact/aws-codeartifact-repository/.hypothesis/examples')
rootdir: /Volumes/Unix/workplace/aws-cloudformation-resource-providers-codeartifact/aws-codeartifact-repository, inifile: /private/var/folders/n_/7tmz09ds2gv06hqgr5ry6sr8n8z_lw/T/pytest_9z3lf84d.ini
plugins: localserver-0.5.0, random-order-1.0.4, hypothesis-5.19.2
collected 16 items

handler_create.py::contract_create_delete PASSED                                                                                                                                                                                           [  6%]
handler_create.py::contract_invalid_create PASSED                                                                                                                                                                                          [ 12%]
handler_create.py::contract_create_duplicate SKIPPED                                                                                                                                                                                       [ 18%]
handler_create.py::contract_create_read_success PASSED                                                                                                                                                                                     [ 25%]
handler_create.py::contract_create_list_success PASSED                                                                                                                                                                                     [ 31%]
handler_delete.py::contract_delete_read PASSED                                                                                                                                                                                             [ 37%]
handler_delete.py::contract_delete_list PASSED                                                                                                                                                                                             [ 43%]
handler_delete.py::contract_delete_update PASSED                                                                                                                                                                                           [ 50%]
handler_delete.py::contract_delete_delete PASSED                                                                                                                                                                                           [ 56%]
handler_delete.py::contract_delete_create SKIPPED                                                                                                                                                                                          [ 62%]
handler_misc.py::contract_check_asserts_work PASSED                                                                                                                                                                                        [ 68%]
handler_read.py::contract_read_without_create PASSED                                                                                                                                                                                       [ 75%]
handler_update.py::contract_update_read_success PASSED                                                                                                                                                                                     [ 81%]
handler_update.py::contract_update_list_success PASSED                                                                                                                                                                                     [ 87%]
handler_update_invalid.py::contract_update_create_only_property PASSED                                                                                                                                                                     [ 93%]
handler_update_invalid.py::contract_update_non_existent_resource PASSED                                                                                                                                                                    [100%]

=================================================================================================== 14 passed, 2 skipped in 1083.74s (0:18:03) ===================================================================================================

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.