search

aws-cloudformation / aws-cloudformation-resource-providers-codeartifact

The CloudFormation Resource Provider Package for the AWS CodeArtifact service
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/AWS_CodeArtifact.html
Apache License 2.0
27 stars 7 forks source link

KMS Pattern #8

Open richardhboyd opened 3 years ago

richardhboyd commented 3 years ago

Can you add a pattern for a valid KMS Key Arn? Do you accept Aliases?

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-codeartifact/blob/master/aws-codeartifact-domain/aws-codeartifact-domain.json#L20

jonjara commented 3 years ago

we do accept alias:

The encryption key for the domain. This is used to encrypt content stored in a domain. An encryption key can be a key ID, a key Amazon Resource Name (ARN), a key alias, or a key alias ARN

According to api doc, the pattern is Pattern: \S+ , this is already a string type so I'll this like this for now.

richardhboyd commented 3 years ago

This fees like one of those times where, in the attempt to give developers the most flexibility, we have made it more confusing. By accepting many different types of values, we have precluded the possibility of automated tools to assist customers in defining this. cfn-lint will accept any string, even emojis?