search

aws-cloudformation / aws-cloudformation-resource-providers-iot

The CloudFormation Resource Provider Package For AWS IoT
Apache License 2.0
1 stars 18 forks source link

Maven build failing #5

Open miparnisari opened 4 years ago

miparnisari commented 4 years ago

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-iot/blob/75e2d5512608b934db48ee6329de0ffb15553162/buildspec.yml#L9-L15

Your CodeBuild config is not building anything. Please change this to something like: 

  build:
    commands:
      - pre-commit run --all-files
      - |
        for directory in $CODEBUILD_SRC_DIR/aws-*; do
          cd "$directory"
          mvn -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -B clean verify --no-transfer-progress
        done
PatMyron commented 3 years ago

Maven builds are failing due to only updating internal Brazil Config file(s) without also updating external Maven pom.xml file(s):

$ grep -L 'software.amazon.awssdk' */*/pom.xml # SDK missing from Maven dependencies
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificate/pom.xml
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthority/pom.xml
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthorityactivation/pom.xml
aws-cloudformation-resource-providers-cloudformation/aws-cloudformation-moduleversion/pom.xml
aws-cloudformation-resource-providers-ec2-cagw/aws-ec2-carriergateway/pom.xml
aws-cloudformation-resource-providers-ec2-prefix-list/aws-ec2-prefixlist/pom.xml
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-accelerator/pom.xml
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-endpointgroup/pom.xml
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-listener/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-authorizer/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-certificate/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-provisioningtemplate/pom.xml
aws-cloudformation-resource-providers-rds-proxy/aws-rds-dbproxy/pom.xml
aws-cloudformation-resource-providers-rds-proxy/aws-rds-dbproxytargetgroup/pom.xml
aws-cloudformation-resource-providers-timestream/aws-timestream-database/pom.xml
aws-cloudformation-resource-providers-timestream/aws-timestream-table/pom.xml