aws-cloudformation / aws-cloudformation-resource-providers-kms

AWS Key Management Service (KMS) makes it easy for you to create and manage cryptographic keys and control their use across a wide range of AWS services and in your applications. AWS KMS is a secure and resilient service that uses hardware security modules that have been validated under FIPS 140-2, or are in the process of being validated, to protect your keys. AWS KMS is integrated with AWS CloudTrail to provide you with logs of all key usage to help meet your regulatory and compliance needs.
https://aws.amazon.com/kms/
Apache License 2.0
14 stars 12 forks source link

Don't run EventualConsistency helper on delete #59

Open brentcetinich opened 7 months ago

brentcetinich commented 7 months ago

CFN is terribly slow and here is an example of unnecessary wait, the eventual consistency helper which waits 60 seconds for every creation, update or delete, I can understand waiting on create KMS keys but for delete it seems unnecessary.

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-kms/blob/master/common/src/main/java/software/amazon/kms/common/KeyHandlerHelper.java#L332

This has ben there for a long time, perhaps there is a faster way to do this now?