aws-cloudformation / aws-cloudformation-resource-providers-logs

The CloudFormation Resource Provider Package For Amazon CloudWatch Logs
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html
Apache License 2.0
33 stars 35 forks source link

Remove unnecessary read calls #21

Closed adam-daily closed 4 years ago

adam-daily commented 5 years ago

Issue #, if available:

Description of changes:

This change removes read calls from the LogGroup Create and Update handlers that could be causing undue stress on Lambda functions.

The change also adds role details generated by RPDK.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rjlohan commented 5 years ago

Probably didn't need to regen the roles in other types but whatevs. 🚂

adam-daily commented 5 years ago

Nice, also might be useful to get rid of the initial read and rely on AlreadyExists being returned from create.

Good call, I'll get rid of it.