The handleError in preCreateCheck method doesn't handle exception well. It treats any other exception as successful. However, it should only treat ResourceNotFound as successful. Any other exception should be Internal error. In such way, it's able to catch the NPE problem.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Issue #, if available:
Description of changes:
Upgrade to 2.0.0 will have unit test fail. There are a couple of things cause those unit test fails:
new CfnAlreadyExistsException(null)
. Also this is pretty bad as without any information as before.handleError
inpreCreateCheck
method doesn't handle exception well. It treats any other exception as successful. However, it should only treatResourceNotFound
as successful. Any other exception should be Internal error. In such way, it's able to catch the NPE problem.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.